Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhancement/Move examples to unit tests #202
Merged
Conversation
c-w
force-pushed the
CatalystCode:enhancement/move-examples-to-tests
branch
from
cefa4c1
to
340209a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedMay 16, 2019
There are some nice test examples of how to use the various classes in
utils.pyin the docstrings. However, doctests don't get executed by default by the Django test runner so we've had no programmatic guarantee that the examples keep up-to-date with the code. To fix this, this change moves the examples to normal unit tests. There is on functional change to the code.