Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Move examples to unit tests #202

Merged

Conversation

@c-w
Copy link
Member

c-w commented May 16, 2019

There are some nice test examples of how to use the various classes in utils.py in the docstrings. However, doctests don't get executed by default by the Django test runner so we've had no programmatic guarantee that the examples keep up-to-date with the code. To fix this, this change moves the examples to normal unit tests. There is on functional change to the code.

@c-w c-w force-pushed the CatalystCode:enhancement/move-examples-to-tests branch from cefa4c1 to 340209a May 20, 2019
@Hironsan Hironsan merged commit ad01f52 into doccano:master May 21, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@c-w c-w deleted the CatalystCode:enhancement/move-examples-to-tests branch May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.