Skip to content

Bugfix/Encode username in Azure DATABASE_URL - #206

Merged
Hironsan merged 5 commits into
doccano:masterfrom
CatalystCode:bugfix/azure-database-url
May 20, 2019
Merged

Bugfix/Encode username in Azure DATABASE_URL#206
Hironsan merged 5 commits into
doccano:masterfrom
CatalystCode:bugfix/azure-database-url

Conversation

@c-w

@c-w c-w commented May 16, 2019

Copy link
Copy Markdown
Member

In the Azure deploy the database user is in the format user@server and it looks like furl doesn't deal well with that. URL-encoding the @ to %40 fixes the problem.

Resolves #203

@c-w c-w changed the title Bugfix/Correctly parse Azure database connection string Bugfix/Correctly format Azure database connection string May 16, 2019
@c-w c-w changed the title Bugfix/Correctly format Azure database connection string Bugfix/Encode username in Azure database connection string May 16, 2019
@c-w c-w changed the title Bugfix/Encode username in Azure database connection string Bugfix/Encode username in Azure DATABASE_URL May 16, 2019
Comment thread azuredeploy.json Outdated
@Hironsan
Hironsan merged commit 3f630d6 into doccano:master May 20, 2019
@c-w
c-w deleted the bugfix/azure-database-url branch May 20, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy to Azure stopped working

3 participants