Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Speed up build #207

Merged
merged 5 commits into from May 23, 2019

Conversation

@c-w
Copy link
Member

c-w commented May 17, 2019

This change makes various improvements to the Docker build in order to improve performance:

  • Patch the static files storage for unit tests so that we can delay collectstatic until after running the tests.
  • Build the full production image only during CD and not during CI.
  • Reduce the static files scope to exclude the files only used by webpack.
  • Introduce a new layer to remove build artifacts from the production image.

The overall impact of these changes is:

  • For branches and pull requests, Docker build times are speed up by ~65% (as measured by time).
  • For changes to master, Docker build times are sped up by ~15% (as measured by time).
  • The final image is ~10% smaller (as measured by docker image inspect).
  • The overall end-to-end time of the Travis build for this branch was ~4 minutes whereas for other branches build times around usually around ~8 minutes.
@Hironsan Hironsan merged commit 6de3a95 into doccano:master May 23, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@c-w c-w deleted the CatalystCode:enhancement/speed-up-build branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.