Skip to content

Enhancement/Document how to run tests#215

Merged
Hironsan merged 1 commit intodoccano:masterfrom
CatalystCode:enhancement/document-how-to-run-tests
May 23, 2019
Merged

Enhancement/Document how to run tests#215
Hironsan merged 1 commit intodoccano:masterfrom
CatalystCode:enhancement/document-how-to-run-tests

Conversation

@c-w
Copy link
Member

@c-w c-w commented May 22, 2019

Resolves #214

@erikamenezes
Copy link
Contributor

Suggestion: Add collectstatic as well?

Also, even though the django tests pass, the CI sometimes breaks due to some style guidelines. So I've found running the tools/ci.sh to be better.

@c-w
Copy link
Member Author

c-w commented May 22, 2019

@erikamenezes Thanks for the suggestion. The need to run collectstatic before the tests will be removed as soon as #207 is merged so I wouldn't document this just now.

I'm hesitant to recommend tools/ci.sh as the default test runner since it won't work on Windows. Ideally we'd re-write the bash scripts in Python so that they can be run cross-platform. I can work on porting the tools to Python or even something slightly more complete like using fabfile or invoke. Thoughts @Hironsan?

@Hironsan
Copy link
Member

It is better to explain only how to run the basic test. It's executable for any developers.

@Hironsan Hironsan merged commit 801baf3 into doccano:master May 23, 2019
@c-w c-w deleted the enhancement/document-how-to-run-tests branch May 23, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running tests fails on import and there is no documentation on testing.

3 participants