Enhancement/Ensure data pagination is covered in tests #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-w
force-pushed
the
enhancement/data-import-coverage
branch
2 times, most recently
from
aff0578 to
7159580
Compare
c-w
changed the title
c-w
force-pushed
the
enhancement/data-import-coverage
branch
from
7159580 to
1087600
Compare
c-w
force-pushed
the
enhancement/data-import-coverage
branch
from
1087600 to
e1ae68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, none of the data import pagination code (
if len(data) >= IMPORT_BATCH_SIZE: yield data) inutils.pywas covered by the unit tests. This pull request adds code coverage for the data import pagination functionality.