Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Ensure data pagination is covered in tests #223

Merged

Conversation

@c-w
Copy link
Member

c-w commented May 24, 2019

Previously, none of the data import pagination code (if len(data) >= IMPORT_BATCH_SIZE: yield data) in utils.py was covered by the unit tests. This pull request adds code coverage for the data import pagination functionality.

@c-w c-w force-pushed the CatalystCode:enhancement/data-import-coverage branch 2 times, most recently from aff0578 to 7159580 May 24, 2019
@c-w c-w changed the title Enhancement/ Ensure data pagination is covered in tests Enhancement/Ensure data pagination is covered in tests May 26, 2019
@c-w c-w force-pushed the CatalystCode:enhancement/data-import-coverage branch from 7159580 to 1087600 May 31, 2019
@c-w c-w force-pushed the CatalystCode:enhancement/data-import-coverage branch from 1087600 to e1ae68c Jun 8, 2019
@Hironsan Hironsan merged commit 427f59b into doccano:master Jun 11, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@c-w c-w deleted the CatalystCode:enhancement/data-import-coverage branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.