Bugfix/Fix CoNLL parsing with trailing newlines#225
Merged
Hironsan merged 1 commit intodoccano:masterfrom May 31, 2019
Merged
Conversation
c-w
force-pushed
the
bugfix/conll-with-trailing-newlines
branch
from
939ebd6 to
7c3116f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a CoNLL file has a trailing newline, we currently silently don't import any data which may be confusing to the user (see for example #218). This pull request fixes the behavior and ensures that if data was correctly parsed from the file, it also gets imported.