Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhancement/Approve labels #258
Merged
Conversation
c-w
force-pushed the
CatalystCode:enhancement/approve-labels
branch
from
290894b
to
8f876d4
c-w
force-pushed the
CatalystCode:enhancement/approve-labels
branch
from
8f876d4
to
974c2ce
c-w
force-pushed the
CatalystCode:enhancement/approve-labels
branch
from
974c2ce
to
d0c566c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedJun 25, 2019
As discussed in #249, it is a very useful feature to enable a type of users to review and approve labels that other users annotated. The review feature for example enables workflows like the ones discussed in #65 where many users can annotate the dataset and then some trusted users can verify the labels before we use them for downstream workflows such as model building.
As such, this pull request implements a simple label review mechanism: admin users now see a button on the annotation page that enables them to approve or reject labels. The approval is shown in the exported datasets so that downstream applications can exclude non-approved labels.
In the future, this feature can be expanded to for example include multiple reviewers per document or to provide a customized "label reviewer" role whose document sort order by default shows labeled but not-reviewed documents first in the annotation view.