Enhancement/Remove demo components#276
Merged
Hironsan merged 4 commits intoJul 9, 2019
Merged
Conversation
c-w
force-pushed
the
enhancement/remove-demo-components
branch
from
July 7, 2019 17:50
10c8ee3 to
4515228
Compare
Member
|
Wonderful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #274, we currently have some code duplication between the demo labeling canvas and the production labeling canvas. This means that new frontend features may have to be implemented twice which slows down the process and may confuse developers.
This pull request refactors the demo pages to use the production labeling canvas. This is achieved by using axios-mock-adapter to intercept the HTTP requests of the production labeling canvas and replacing them with an in-memory implementation. In the future, this same approach can also be leveraged for faking HTTP requests for unit testing the frontend.