Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhancement/Test production databases #278
Merged
Conversation
c-w
force-pushed the
CatalystCode:enhancement/test-production-databases
branch
from
77fd1b7
to
ccbb9b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedJul 8, 2019
Currently in the CI we only run tests against SQLite. However, doccano also supports other databases such as Postgres. In order to ensure that all the databases keep working, this pull request adds a CI step that runs the test suite against non-SQLite databases.
The approach introduced in this pull request also makes it easy to verify new database backends such as SQL Server (see #255).