Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Remove Google Analytics from Azure deployment #320

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@c-w
Copy link
Member

c-w commented Aug 1, 2019

I noticed that all deployments of Doccano to Azure still include the Google Analytics tracking ID. This is because env('GOOGLE_TRACKING_ID', 'UA-125643874-2') with GOOGLE_TRACKING_ID="" set in the environment falls back to the default value instead of using the empty string.

This pull request fixes the behavior and enables users to opt-out of Google Analytics by passing GOOGLE_TRACKING_ID=" ".

@Hironsan Hironsan merged commit ef01fc5 into doccano:master Aug 5, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@c-w c-w deleted the CatalystCode:bugfix/google-analytics branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.