Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Fix filename determination with URL querystring #344

Merged

Conversation

@c-w
Copy link
Member

c-w commented Aug 20, 2019

The preview Vue component contains logic to determine a file's type given an access URL. This pull request fixes that logic for the case where a URL contains a querystring such as http://some/file.pdf?q=1.

@Hironsan Hironsan merged commit cf7d827 into doccano:master Aug 21, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@c-w c-w deleted the CatalystCode:bugfix/preview-filename-with-querystring branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.