Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Add settings required for SSL #350

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@c-w
Copy link
Member

c-w commented Aug 24, 2019

Many of doccano's settings are currently configurable via the environment as per the 12-factor methodology. This pull request extends the configuration to also include settings required to run doccano successfully behind an SSL terminating proxy. The change is fully backwards compatible since by default the new environment variables are disabled.

Example environment configuration to enable custom SSL:

export SESSION_COOKIE_SECURE="True"
export CSRF_COOKIE_SECURE="True"
export CSRF_TRUSTED_ORIGINS="some.domain.com"
@Hironsan Hironsan merged commit ff892d4 into doccano:master Nov 18, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@c-w c-w deleted the CatalystCode:enhancement/ssl-settings branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.