Enhancement/Improve annotation creation performance#390
Merged
Hironsan merged 2 commits intodoccano:masterfrom Nov 19, 2019
Merged
Conversation
c-w
force-pushed
the
enhancement/improve-annotation-creation-performance
branch
from
33bb417 to
a87ed71
Compare
c-w
force-pushed
the
enhancement/improve-annotation-creation-performance
branch
from
a87ed71 to
b40b2e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed slowdowns in the annotation workflow with large documents, similar to the what has been described in #144.
The slowdowns seem to be linked to the performance of two requests:
GET /v1/projects/<project_id>/statisticsPOST /v1/projects/<project_id>/docs/<doc_id>/annotationsThis pull request improves the performance of the annotation creation workflow via two main optimizations:
Avoid computing the label and user keys in the statistics response after a new annotation has been created (these properties get used on the stats page, not the annotations page). This saves a database aggregation query.
Avoid pulling back the full document from the database on annotation creation (the annotation object only has a link to the document so we can use the document id to create the annotation and don't need to hydrate a full document object reference). This saves a database read that may potentially be expensive if the document is large as we may be pulling back thousands of lines of text from the database into the Django server.