Bugfix/Enable editing of labels with shortcut keys #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-w
force-pushed
the
bugfix/edit-label-with-shortcut
branch
2 times, most recently
from
1a466a3 to
f195929
Compare
c-w
force-pushed
the
bugfix/edit-label-with-shortcut
branch
from
f195929 to
8222ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #379, it's currently not possible to edit a label that has a shortcut key set. This is because in the LabelSerializer we're checking if any other label has the same prefix or suffix key as the serialized label:
https://github.com/chakki-works/doccano/blob/55c6cc27abfdd9d8ab8cfc4ef493116519f750c4/app/api/serializers.py#L43-L46
However, if we're editing a label and not changing its prefix or suffix key, the check will always retrieve the currently edited label as a conflict. The solution to this problem implemented in this pull request is to exclude the currently edited label from the check.
Resolves #379