Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Enable superuser to delete user annotations #398

Merged

Conversation

@c-w
Copy link
Member

c-w commented Oct 11, 2019

As reported in #385, superusers currently can't delete annotations created by another user. This pull request enables superusers to delete annotations even if they were created by another user.

Resolves #385

@jonhilgart22

This comment has been minimized.

Copy link

jonhilgart22 commented Oct 16, 2019

Bump! Can we merge this in :)

@prokotg

This comment has been minimized.

Copy link

prokotg commented Oct 23, 2019

hey ! Thank you for this contribution! As I can see,there is only super user you consider rn. When I look at administration panel where I give users permissions (through groups) there isan option for a user to have the following permissions
image
Should not they also be able to change other people's annotations? Or do I miss sth out here?

Cheers! :)

@c-w c-w force-pushed the CatalystCode:bugfix/superuser-delete-annotation branch from dfd2d4b to 6d3db4c Oct 25, 2019
@Hironsan Hironsan merged commit 9049a6b into doccano:master Nov 18, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@c-w c-w deleted the CatalystCode:bugfix/superuser-delete-annotation branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.