Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Add support for MySQL #422

Merged
merged 2 commits into from Nov 28, 2019
Merged

Conversation

@c-w
Copy link
Member

c-w commented Oct 25, 2019

According to the StackOverflow survey, MySQL, PostgreSQL and SQL Server are the most popular databases for developers. Given that doccano already supports the later two; this pull request also adds support for MySQL so that doccano covers all the widely used databases.

The changes required to support MySQL are fairly minimal:

  1. The migrations had to be squashed since the manage.py migrate command crashed on MySQL during some of the AlterUniqueTogether calls.
  2. MySQL doesn't support the sslmode=require option and instead requires a certificate to validate the SSL connection to the server. A path to this certificate can now be configured via the MYSQL_SSL_CA environment variable.

Integration tests have been added to TravisCI to ensure that future changes don't break compatibility with MySQL.

@Hironsan Hironsan added this to To do in v1.0.2 Nov 22, 2019
@Hironsan Hironsan moved this from To do to In progress in v1.0.2 Nov 26, 2019
@Hironsan Hironsan merged commit 9e48b82 into doccano:master Nov 28, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@c-w c-w deleted the CatalystCode:enhancement/mysql branch Nov 28, 2019
@Hironsan Hironsan moved this from In progress to Done in v1.0.2 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.0.2
  
Done
2 participants
You can’t perform that action at this time.