Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhancement/Add support for MySQL #422
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedOct 25, 2019
According to the StackOverflow survey, MySQL, PostgreSQL and SQL Server are the most popular databases for developers. Given that doccano already supports the later two; this pull request also adds support for MySQL so that doccano covers all the widely used databases.
The changes required to support MySQL are fairly minimal:
manage.py migratecommand crashed on MySQL during some of theAlterUniqueTogethercalls.sslmode=requireoption and instead requires a certificate to validate the SSL connection to the server. A path to this certificate can now be configured via theMYSQL_SSL_CAenvironment variable.Integration tests have been added to TravisCI to ensure that future changes don't break compatibility with MySQL.