Enhancement/Add guest user role #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a "guest" or "view only" role to doccano that enables viewing of project documents and annotations but not creation or modification thereof.
The pull request also fixes a number of additional minor issues related to RBAC:
The
add_new_superuser_to_projectsfunctions which grants all superusers the admin role on projects wasn't being exercised for admins that were created before the RBAC functionality was introduced. To backport the RBAC functionality to old instances of doccano, the functionality is now being called on server start when we create the default project roles.The
get_current_users_rolefunction had a hard-coded list of roles. To make it easier to add new roles in the future, the function has been refactored to dynamically look up all roles.Resolves #413