Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Add volume for SQLite DB in doccano container #441

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@c-w
Copy link
Member

c-w commented Nov 11, 2019

This pull request moves the SQLite database file used in Doccano's Dockerfile to a dedicated directory /data and binds this directory using a VOLUME instruction.

This enables us to persist Doccano's database file across container restarts in a filesystem/platform independent way. The README has been updated with instructions on how to leverage this functionality.

Resolves #438

README.md Outdated Show resolved Hide resolved
@orico

This comment has been minimized.

Copy link

orico commented Nov 17, 2019

did you merge this yet?

@c-w c-w force-pushed the CatalystCode:enhancement/docker-volume branch from 4f2625a to fa4d92e Nov 21, 2019
@Hironsan Hironsan added this to To do in v1.0.2 Nov 22, 2019
@Hironsan Hironsan mentioned this pull request Nov 25, 2019
@Hironsan Hironsan merged commit 2ebc729 into doccano:master Nov 26, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@Hironsan Hironsan moved this from To do to Done in v1.0.2 Nov 26, 2019
@c-w c-w deleted the CatalystCode:enhancement/docker-volume branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.0.2
  
Done
4 participants
You can’t perform that action at this time.