Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Verification emails on Azure #504

Merged

Conversation

@c-w
Copy link
Member

c-w commented Dec 18, 2019

In #250, @guillim introduced the ability for users to self-service sign-up for new Doccano accounts. This pull request ensures that the sign-up functionality works out-of-the-box in the Azure deployment which required a few changes:

  1. Enabling configuring the email backend settings via environment variables so that deployments can turn on the feature without requiring a code change.
  2. Removing hard-coded HTTP scheme the activation link sent in activation email so that the link also works on deployments that use HTTPS.
  3. Adding a Sendgrid resource to the Azure deployment. By default this uses the free tier which covers 25,000 emails per month (see pricing).

Additionally, the wording of the account activation email has been slightly changed to ensure that users know that the email comes from Doccano and we now default to the console email backend to prevent crashes when running locally.

@Hironsan Hironsan merged commit 5942bbf into doccano:master Jan 10, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@c-w c-w deleted the CatalystCode:enhancement/verification-emails-on-azure branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.