Bugfix/Flags set on project creation are discarded#532
Merged
Hironsan merged 5 commits intoJan 27, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a project is created with the "share annotations across all users" checkbox ticked, the
collaborative_annotationoption isn't set in the created project. This is due to code duplication in the variousProjectSerializersubclasses which led to a drift in thefieldsandread_only_fieldsbetween the various subclasses. This pull request fixes the issue by removing the code duplication and having one canonical set offieldsandread_only_fieldswhich is consistent across all subclasses of the project serializer.Resolves #519