Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Flags set on project creation are discarded #532

Open
wants to merge 5 commits into
base: master
from

Conversation

@c-w
Copy link
Member

c-w commented Jan 10, 2020

Currently if a project is created with the "share annotations across all users" checkbox ticked, the collaborative_annotation option isn't set in the created project. This is due to code duplication in the various ProjectSerializer subclasses which led to a drift in the fields and read_only_fields between the various subclasses. This pull request fixes the issue by removing the code duplication and having one canonical set of fields and read_only_fields which is consistent across all subclasses of the project serializer.

Resolves #519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.