Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Okta support #675

Merged
merged 8 commits into from
Jul 28, 2020
Merged

Add Okta support #675

merged 8 commits into from
Jul 28, 2020

Conversation

setu4993
Copy link
Contributor

@setu4993 setu4993 commented Apr 8, 2020

First time-contributor and working with OAuth / Django. I took inspiration from #75 but I probably missed some things. Would appreciate some help on the tests to add, and missing changes required.
Resolves #674.

@setu4993
Copy link
Contributor Author

Hi @Hironsan, @c-w, rest of the team. Please review this when you have a chance.

@setu4993
Copy link
Contributor Author

setu4993 commented Apr 24, 2020

Hello @Hironsan, @c-w, I think this PR is now ready for review. I have added everything that I could see and tested it using an Okta domain.

Looking forward to feedback on this.

@setu4993 setu4993 force-pushed the feature/oauth_okta branch 4 times, most recently from 0c85030 to 2422bc4 Compare April 24, 2020 06:32
@setu4993 setu4993 force-pushed the feature/oauth_okta branch 2 times, most recently from cfa25b8 to e6a1b94 Compare May 7, 2020 16:45
@setu4993
Copy link
Contributor Author

Hi @Hironsan, @c-w, @icoxfog417, please review this when you have a chance.

The code quality failing CI is from the test where it assumes there's a hard-coded password or secret.

@setu4993 setu4993 mentioned this pull request Jul 15, 2020
40 tasks
app/server/tests/test_social_auth.py Outdated Show resolved Hide resolved
app/requirements.txt Show resolved Hide resolved
app/requirements.txt Outdated Show resolved Hide resolved
app/server/social_auth.py Outdated Show resolved Hide resolved
@setu4993
Copy link
Contributor Author

Thanks for the review and feedback, @c-w. I've updated the PR based on your comments, and the CI build is also passing.

app/requirements.txt Outdated Show resolved Hide resolved
@Hironsan
Copy link
Member

Is this WIP or finished?

@setu4993
Copy link
Contributor Author

@Hironsan : Hi, this is finished and ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Okta Integration for OAuth
3 participants