Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add Dockerfile #68

Merged
merged 5 commits into from Jan 25, 2019
Merged

Feature/Add Dockerfile #68

merged 5 commits into from Jan 25, 2019

Conversation

@c-w
Copy link
Member

c-w commented Jan 23, 2019

As per https://github.com/chakki-works/doccano/projects/2#card-16406087, this change adds a Dockerfile for the project.

The Python distribution used by the image can be specified via a build-time argument. This enables us in the future to for example run the tests on a wide variety of Python versions.

In the future, the Dockerfile could be extended to for example leverage multi-stage builds. In this case, the first stage could run tests, linter, and so forth and then create a wheel or similar artifact via setuptools. A second stage in the build can then only include a minimal set of dependencies to install and run the artifact (e.g. using python-slim as a base image).

@c-w c-w force-pushed the CatalystCode:feature/docker branch from cc580d3 to 2c94bd9 Jan 23, 2019
c-w added 3 commits Jan 23, 2019
As per https://github.com/chakki-works/doccano/projects/2#card-16406087,
this change adds a Dockerfile for the project.

The Python distribution used by the image can be specified via a
build-time argument. This enables us in the future to for example run
the tests on a wide variety of Python versions.

In the future, the Dockerfile could be extended to for example leverage
multi-stage builds. In this case, the first stage could run tests,
linter, and so forth and then create a wheel or similar artifact via
setuptools. A second stage in the build can then only include a minimal
set of dependencies to install and run the artifact (e.g. using
python-slim as a base image).
@c-w c-w force-pushed the CatalystCode:feature/docker branch from 2c94bd9 to c1a22bd Jan 24, 2019
@c-w c-w force-pushed the CatalystCode:feature/docker branch 2 times, most recently from 2ca28cb to c72a7c4 Jan 24, 2019
Also: ignore files generated during application run which enables a
better development experience in Docker with source mounts like
`docker run -p 8080:80 -v $PWD:/doccano -it doccano`.
@c-w c-w force-pushed the CatalystCode:feature/docker branch from c72a7c4 to 0b1f464 Jan 24, 2019
@Hironsan Hironsan assigned Hironsan and unassigned c-w Jan 25, 2019
@Hironsan Hironsan merged commit d9e15e4 into doccano:master Jan 25, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Hironsan

This comment has been minimized.

Copy link
Member

Hironsan commented Jan 25, 2019

Thanks for your contribution!

@BrambleXu BrambleXu added this to PR Status in v1.0.0 Jan 28, 2019
@c-w c-w deleted the CatalystCode:feature/docker branch Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.0.0
PR Status
3 participants
You can’t perform that action at this time.