Merged
Conversation
As per https://github.com/chakki-works/doccano/projects/2#card-16406087, this change adds a Dockerfile for the project. The Python distribution used by the image can be specified via a build-time argument. This enables us in the future to for example run the tests on a wide variety of Python versions. In the future, the Dockerfile could be extended to for example leverage multi-stage builds. In this case, the first stage could run tests, linter, and so forth and then create a wheel or similar artifact via setuptools. A second stage in the build can then only include a minimal set of dependencies to install and run the artifact (e.g. using python-slim as a base image).
c-w
force-pushed
the
feature/docker
branch
2 times, most recently
from
2ca28cb to
c72a7c4
Compare
Also: ignore files generated during application run which enables a better development experience in Docker with source mounts like `docker run -p 8080:80 -v $PWD:/doccano -it doccano`.
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://github.com/chakki-works/doccano/projects/2#card-16406087, this change adds a Dockerfile for the project.
The Python distribution used by the image can be specified via a build-time argument. This enables us in the future to for example run the tests on a wide variety of Python versions.
In the future, the Dockerfile could be extended to for example leverage multi-stage builds. In this case, the first stage could run tests, linter, and so forth and then create a wheel or similar artifact via setuptools. A second stage in the build can then only include a minimal set of dependencies to install and run the artifact (e.g. using python-slim as a base image).