Skip to content

Feature/Add flake8 linter#74

Merged
Hironsan merged 2 commits intodoccano:masterfrom
CatalystCode:feature/flake8
Jan 27, 2019
Merged

Feature/Add flake8 linter#74
Hironsan merged 2 commits intodoccano:masterfrom
CatalystCode:feature/flake8

Conversation

@c-w
Copy link
Member

@c-w c-w commented Jan 25, 2019

In order to ensure a consistent code style and to find potential bugs not uncovered by tests, this change adds the flake8 linter to the project's CI.

The pull request also fixes all the existing flake8 violations:

  • F403 and F405: wildcard imports.
  • E501: line too long.
  • F481: unused variable.
  • E128, E231, E261, E265, E302, E303, W293, W291: whitespace.

@BrambleXu BrambleXu mentioned this pull request Jan 25, 2019
3 tasks
@Hironsan Hironsan merged commit 0e6718a into doccano:master Jan 27, 2019
@c-w c-w deleted the feature/flake8 branch January 28, 2019 01:56
@BrambleXu BrambleXu added the enhancement Improvement on existing feature label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments