-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Add social login via Github and Active Directory #75
Conversation
Nice feature! In I tried to login vie GitHub OAuth, then I had an Authentication Failed error: According to the Python Social Auth documentation, I changed the url from above to below. It works fine: # path('social/', include('social_django.urls')),
path(r'', include('social_django.urls', namespace='social')), Do we need any additional settings? |
@Hironsan Thanks for your review! Unlike the social_django documentation, I've used So for example the Github complete URL will now be I believe that having the Could you try with the branch's code and change the Github callback URL in your OAuth application registration to include the |
I agree with you. It works fine. Thank you! |
Simple documentation: |
Currently the workflow for adding new users to a doccano instance requires an administrator to create accounts using the Django admin tool. This puts a burden on the admin. It also puts a burden on the user since they must maintain a dedicated account and password to access this application. See also the discussion on card-16405801 around user management.
To make it easier for annotators to do work on doccano, I suggest to add social authentication to the application. This means that a user can sign up with the social provider and get invited to work on annotation projects using that social identity.
As a first step, this pull request implements Github and Azure Active Directory authentication but other social identities should be easily added in the future. This pull request does not solve the problem of having an easy creation of admin users who can create new projects, but at least it makes it simple for annotators to join and work on a project.
Screenshot of the updated login page: