Skip to content

Feature/Make client-side analytics configurable#76

Merged
Hironsan merged 6 commits intodoccano:masterfrom
CatalystCode:feature/configurable-google-analytics
Jan 29, 2019
Merged

Feature/Make client-side analytics configurable#76
Hironsan merged 6 commits intodoccano:masterfrom
CatalystCode:feature/configurable-google-analytics

Conversation

@c-w
Copy link
Copy Markdown
Member

@c-w c-w commented Jan 25, 2019

The doccano application currently contains Google Analytics with a hard-coded tracking ID. This means that every deployment of doccano will send analytics to the same account. In order to support new deployments of doccano bringing their own analytics, this change makes the Google Analytics tracking ID configurable via a setting.

Additionally, the Google Analytics Javascript will now only be included in the page if the tracking ID is present which means that deployments can also opt-out of Google Analytics altogether.

For users who're looking for an alternative to Google Analytics, this change also adds an option to use Azure Application Insights for client-side monitoring.

@c-w c-w changed the title Feature/Make Google Analytics configurable Feature/Make client-side analytics configurable Jan 27, 2019
@BrambleXu BrambleXu added the enhancement Improvement on existing feature label Jan 28, 2019
@c-w c-w force-pushed the feature/configurable-google-analytics branch from 543b91a to 7f6cce2 Compare January 28, 2019 12:40
@c-w c-w force-pushed the feature/configurable-google-analytics branch from c6b5174 to e4fd74e Compare January 28, 2019 13:25
@Hironsan
Copy link
Copy Markdown
Member

Hironsan commented Jan 29, 2019

The doccano application currently contains Google Analytics with a hard-coded tracking ID.

To tell the truth, I embedded the hard-coded tracking ID for knowing how many people are using doccano. Through Google Analytics, I can know the number and it motivated me a lot:

image

But I can understand what you say. This feature is useful for people who want to set their own ID.

Hmmm...

Is there any way to know how many users using doccano but at the same time the user can set their own ID?

@Hironsan Hironsan merged commit 97b435d into doccano:master Jan 29, 2019
@Hironsan
Copy link
Copy Markdown
Member

No problem. I really appreciate your help.

@c-w c-w deleted the feature/configurable-google-analytics branch January 29, 2019 13:15
@c-w
Copy link
Copy Markdown
Member Author

c-w commented Jan 29, 2019

Wow, great to see the usage. In any case, even after this merge, the tracking ID still defaults to yours; the user actively must set the environment variable to an empty string to remove the tracking (like GOOGLE_TRACKING_ID=""). Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants