Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Remember labeling progress #79

Merged
merged 3 commits into from Jan 29, 2019

Conversation

@c-w
Copy link
Member

c-w commented Jan 28, 2019

This pull request implements a small improvement to the labeling view: the labeling view now remembers the current page by syncing the current query offset to the URL fragment.

This enables "deep linking" where a user who's doing a labeling session could bookmark the current page and later resume work from where they stopped. See also #58.

Ideally the feature would use vue-router instead of the custom fragment manipulation, but that would be a bigger change so for now I wanted to minimize the amount of new code.

Screenshot showing offset state in URL:

Screenshot showing offset state in URL

@Hironsan Hironsan merged commit a58d15b into doccano:master Jan 29, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@c-w c-w deleted the CatalystCode:enhancement/remember-progress branch Jan 29, 2019
@c-w c-w mentioned this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.