Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Auto-generate bundle files #80

Merged

Conversation

@c-w
Copy link
Member

c-w commented Jan 28, 2019

I noticed that the webpack outputs are currently checked into the repository. This is nice since it enables a simple deployment model with git push to Heroku. However, it also somewhat pollutes the repository and diffs since the bundle files are auto-generated; so it would be nice to remove these auto-generated files from the repo. Additionally, removing the generated files from the project means that the documentation now must contain instructions on how to build the frontend which helps with onboarding.

Given that we recently introduced a Dockerfile for the application, I suggest to move the Heroku deployment to use the Docker image and create the webpack assets as part of the Docker build. In this way we get the best of all the worlds: a simple setup for deployment and development (just a docker build and docker run) and no generated files checked into the repository.

This change will also make it easier to move to a fully integrated solution such as Django Webpack Loader in the future.

@Hironsan Hironsan merged commit 4eafc4b into doccano:master Feb 18, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Hironsan added a commit that referenced this pull request Feb 18, 2019
@c-w

This comment has been minimized.

Copy link
Member Author

c-w commented Feb 18, 2019

Thanks for the merge!

@c-w c-w deleted the CatalystCode:enhancement/generate-bundle-files branch Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.