Enhancement/Auto-generate bundle files #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I noticed that the webpack outputs are currently checked into the repository. This is nice since it enables a simple deployment model with git push to Heroku. However, it also somewhat pollutes the repository and diffs since the bundle files are auto-generated; so it would be nice to remove these auto-generated files from the repo. Additionally, removing the generated files from the project means that the documentation now must contain instructions on how to build the frontend which helps with onboarding.
Given that we recently introduced a Dockerfile for the application, I suggest to move the Heroku deployment to use the Docker image and create the webpack assets as part of the Docker build. In this way we get the best of all the worlds: a simple setup for deployment and development (just a docker build and docker run) and no generated files checked into the repository.
This change will also make it easier to move to a fully integrated solution such as Django Webpack Loader in the future.