Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate transition to GitHub action #69

Closed
jcfr opened this issue Mar 3, 2021 · 8 comments
Closed

Evaluate transition to GitHub action #69

jcfr opened this issue Mar 3, 2021 · 8 comments

Comments

@jcfr
Copy link
Member

jcfr commented Mar 3, 2021

See https://github.com/dockcross/dockcross/blob/master/.github/workflows/main.yml

@jcfr
Copy link
Member Author

jcfr commented Mar 3, 2021

@thewtex @JonasVautherin For each dockcross images, are we pushing on dockhub both the latest and YYYYMMDD-SHA{7} tag ?

Looking at dockhub I see both but I am not sure where this happening in the CI configuration

@JonasVautherin
Copy link

It's just doing docker image push dockcross/${{ matrix.arch_name }} (which for android-arm would be docker image push dockcross/android-arm).

I must say I don't know exactly how that works internally, e.g. does it actively push a latest tag, or does the server move the latest cursor whenever a new image is pushed? I would intuitively think about the latter, but I don't know 😄

@thewtex
Copy link
Collaborator

thewtex commented Mar 9, 2021

By default, Docker pushes to the latest tag

We will have to re-add pushes of the date-sha tags.

@JonasVautherin
Copy link

@thewtex: it seems to me that the date tags are pushed:

20210210-84c47e5
Last pushed a month ago by dockcrossci

I did not push them manually, so it has to come from the CI, right?

@thewtex
Copy link
Collaborator

thewtex commented Mar 11, 2021

@JonasVautherin do you have a link for this?

When I check here:

https://hub.docker.com/r/dockcross/base/tags?page=1&ordering=last_updated

I get only get an updated latest:

image

@JonasVautherin
Copy link

JonasVautherin commented Mar 11, 2021

This one from @jcfr message above: https://hub.docker.com/r/dockcross/manylinux2014-x64/tags?page=1&ordering=last_updated

But you're right, dockcross/base is not... 🤔

Isn't it because in the Makefile, they use $(TAG) (see here), but base does not (see here)? Let me try that...

EDIT: and actually that would answer the initial question 😆. The tag is made by the Makefile, and docker push image pushes both tags. Would that make sense?

@thewtex
Copy link
Collaborator

thewtex commented Mar 12, 2021

EDIT: and actually that would answer the initial question laughing. The tag is made by the Makefile, and docker push image pushes both tags. Would that make sense?

Yes! Thanks for the follow-up -- looks like we are in good shape 💪 .

@thewtex thewtex closed this as completed Mar 12, 2021
@thewtex
Copy link
Collaborator

thewtex commented Mar 18, 2021

EDIT: and actually that would answer the initial question laughing. The tag is made by the Makefile, and docker push image pushes both tags. Would that make sense?

Yes, thanks @JonasVautherin for the investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants