Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@aranaea
Copy link
Contributor

@aranaea aranaea commented Jun 26, 2016

This fixes issue #44. On my system I was not getting a valid docker executable. I couldn't find a way to directly download the docker client, even using the url constructed in the code. I could find a tgz file, though. This change pulls the tgz file for your version and copies out the docker client.

Tested with Docker 1.11.2

@gdevillele
Copy link
Contributor

Thanks for contributing.
Could would please run go fmt ./go/src/gosetup/main.go please?
So that the file you edited is formatted correctly.

Except this, it LGTM.
(We must find a reliable mirror to download docker binaries from, though)

@gdevillele
Copy link
Contributor

Ok,
we must use the .tgz suffix for docker 1.11 and up but keep the previous way of getting docker binaries for version 1.10.x and older. @aranaea, could you update your PR to do that, so it doesn't break for 1.10 version and older? Thanks.

@aranaea
Copy link
Contributor Author

aranaea commented Jun 28, 2016

Sure thing. I should have an update in a couple days.

@aranaea
Copy link
Contributor Author

aranaea commented Jun 30, 2016

@gdevillele These latest commits are working for me but I can't easily test with versions older than 1.11.0. If you find that it's broken for older versions I can set something up so that I can address the problems.

Also, this is really the first go that I've written so please let me know if it looks weird.

@gdevillele
Copy link
Contributor

LGTM. Thank you.

@gdevillele gdevillele merged commit ad46f8f into docker-archive-public:master Jul 7, 2016
gdevillele added a commit to gdevillele/dockercraft that referenced this pull request Aug 16, 2016
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
dave-tucker pushed a commit to dave-tucker/dockercraft that referenced this pull request Aug 16, 2016
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
(cherry picked from commit 4e81969)
dave-tucker pushed a commit to dave-tucker/dockercraft that referenced this pull request Aug 16, 2016
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
(cherry picked from commit 4e81969)
dave-tucker pushed a commit to dave-tucker/dockercraft that referenced this pull request Aug 16, 2016
Signed-off-by: Gaetan de Villele <gdevillele@gmail.com>
(cherry picked from commit 4e81969)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants