This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Add configs bind mount support #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssessouza
force-pushed
the
add-configs-bind
branch
from
975a826 to
82b64ee
Compare
ndeloof
approved these changes
Feb 4, 2021
| return nil, err | ||
| } | ||
| mounts[mount.Target] = mount | ||
| m[bindMount.Target] = bindMount |
Collaborator
There was a problem hiding this comment.
I'll never get used with this golang habit to use single letter variables...
Contributor
There was a problem hiding this comment.
same for me... Javaist thing probably :)
ulyssessouza
force-pushed
the
add-configs-bind
branch
from
82b64ee to
dbfe2ca
Compare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
add-configs-bind
branch
from
dbfe2ca to
8d8934e
Compare
gtardif
approved these changes
Feb 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add configs bind mount read-only support
Related issue
Resolves #937