Remove vanity variant support completely #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added so we could support the really-ancient-now "vanity" DockerCon variants of the image, `hello-seattle` and `hola-mundo`, neither of which have been supported/updated in a very long time (and never should've been to begin with).
yosifkit
approved these changes
Nov 19, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 20, 2025
Changes: - docker-library/hello-world@8f82320: Remove 1809 `Dockerfile` (missed in the result of a rebase) - docker-library/hello-world@b981b1c: Merge pull request docker-library/hello-world#130 from infosiftr/no-vanity - docker-library/hello-world@1f2052d: Remove vanity variant support completely
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 20, 2025
Changes: - docker-library/hello-world@a1942f2: Merge pull request docker-library/hello-world#131 from infosiftr/GitCommit - docker-library/hello-world@13898d9: Stop calculating so many individual `GitCommit` values - docker-library/hello-world@8f82320: Remove 1809 `Dockerfile` (missed in the result of a rebase) - docker-library/hello-world@b981b1c: Merge pull request docker-library/hello-world#130 from infosiftr/no-vanity - docker-library/hello-world@1f2052d: Remove vanity variant support completely
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 25, 2025
Changes: - docker-library/hello-world@a1942f2: Merge pull request docker-library/hello-world#131 from infosiftr/GitCommit - docker-library/hello-world@13898d9: Stop calculating so many individual `GitCommit` values - docker-library/hello-world@8f82320: Remove 1809 `Dockerfile` (missed in the result of a rebase) - docker-library/hello-world@b981b1c: Merge pull request docker-library/hello-world#130 from infosiftr/no-vanity - docker-library/hello-world@1f2052d: Remove vanity variant support completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added so we could support the really-ancient-now "vanity" DockerCon variants of the image,
hello-seattleandhola-mundo, neither of which have been supported/updated in a very long time (and never should've been to begin with).Closes #122 (this isn't 100% done, but it's better than the current state, so might as well actually open it instead of letting it sit and rot further and further improvements can be follow-ups over time)