Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You removed git!!!!! Builds broken, sadness everywhere! #180

Closed
peterhyvonen opened this Issue Mar 28, 2018 · 15 comments

Comments

Projects
None yet
8 participants
@peterhyvonen
Copy link

peterhyvonen commented Mar 28, 2018

Your commit around 4pm PST removed git from the docker image! We were using that :( While we have a work around we would very much like not to have to keep our own docker images. It would be great if we could get git back in the image. Thank you from the continuous delivery team at Tableau Software!

docker-library/repo-info@47546ea#diff-a9f6b16b8ccbc61abba418e4d35bbf6d

@voy13k

This comment has been minimized.

Copy link

voy13k commented Mar 28, 2018

Yes, trying to use maven image, based off this (openjdk:8-jdk) - no git, no svn.
How is it even possible if, according to Dockerfile, 8-jdk is based on buildpack-deps:stretch-scm ?

@michalborek

This comment has been minimized.

Copy link

michalborek commented Mar 28, 2018

Any good replacement for now ?

@jansauer

This comment has been minimized.

Copy link

jansauer commented Mar 28, 2018

We switched to using circleci/openjdk:8-jdk. Had to reset our build caches because of wrong file permissions but other then that ...

@GingerGeek

This comment has been minimized.

Copy link

GingerGeek commented Mar 28, 2018

I too am confused how this has happened considering the dependency on buildpack-deps:stretch-scm - more curious as to whether this was an error or a deliberate change.

@tianon

This comment has been minimized.

Copy link
Member

tianon commented Mar 28, 2018

@tianon

This comment has been minimized.

Copy link
Member

tianon commented Mar 28, 2018

We found the source of the issue, have fixed that, and are redoing builds as quickly as possible. ❤️

@GingerGeek

This comment has been minimized.

Copy link

GingerGeek commented Mar 28, 2018

Thanks, will this effect downstream library projects automagically? (e.g maven library images). Would also be interested to hear what went wrong if you can share!

@peterhyvonen

This comment has been minimized.

Copy link
Author

peterhyvonen commented Mar 28, 2018

Thank you for your quick response!

@tianon

This comment has been minimized.

Copy link
Member

tianon commented Mar 28, 2018

Yeah, we're definitely going to rebuild all downstream issues caused by this. It was a mis-tagging of the FROM for the multi-architecture builds -- we somehow managed to tag buildpack-deps:stretch-curl as buildpack-deps:jessie-scm, which had about the effect you'd expect. 😅

@peterhyvonen

This comment has been minimized.

Copy link
Author

peterhyvonen commented Mar 28, 2018

Do we ETA on when I should be able to consume openjdk:8???

@yosifkit

This comment was marked as outdated.

Copy link
Member

yosifkit commented Mar 28, 2018

The amd64 builds are fine now. I'm checking on other architectures now.

$ docker pull openjdk:8
8: Pulling from library/openjdk
c73ab1c6897b: Already exists 
1ab373b3deae: Already exists 
b542772b4177: Already exists 
0bcc3741ab14: Pull complete 
421d624d778d: Pull complete 
26ad58237506: Pull complete 
88ad3b24382b: Pull complete 
776df9bf9f1b: Pull complete 
Digest: sha256:ee9dc6c814d8b23f3b2f1fc142da32de74727f69defbb5e35a0e53078e3d7380
Status: Downloaded newer image for openjdk:8
$ docker history --no-trunc openjdk:8
IMAGE                                                                     CREATED             CREATED BY                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     SIZE                COMMENT
sha256:81e2e1523156c1825abb224701339d8459c55ac3193950d8079ca72a6c4a076d   24 hours ago        /bin/sh -c /var/lib/dpkg/info/ca-certificates-java.postinst configure                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          394kB               
<missing>                                                                 24 hours ago        /bin/sh -c set -ex;   if [ ! -d /usr/share/man/man1 ]; then   mkdir -p /usr/share/man/man1;  fi;   apt-get update;  apt-get install -y   openjdk-8-jdk="$JAVA_DEBIAN_VERSION"   ca-certificates-java="$CA_CERTIFICATES_JAVA_VERSION"  ;  rm -rf /var/lib/apt/lists/*;   [ "$(readlink -f "$JAVA_HOME")" = "$(docker-java-home)" ];   update-alternatives --get-selections | awk -v home="$(readlink -f "$JAVA_HOME")" 'index($3, home) == 1 { $2 = "manual"; print | "update-alternatives --set-selections" }';  update-alternatives --query java | grep -q 'Status: manual'   451MB               
<missing>                                                                 25 hours ago        /bin/sh -c #(nop)  ENV CA_CERTIFICATES_JAVA_VERSION=20170531+nmu1                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                              0B                  
<missing>                                                                 25 hours ago        /bin/sh -c #(nop)  ENV JAVA_DEBIAN_VERSION=8u162-b12-1~deb9u1                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  0B                  
<missing>                                                                 25 hours ago        /bin/sh -c #(nop)  ENV JAVA_VERSION=8u162                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      0B                  
<missing>                                                                 25 hours ago        /bin/sh -c #(nop)  ENV JAVA_HOME=/docker-java-home                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             0B                  
<missing>                                                                 2 weeks ago         /bin/sh -c ln -svT "/usr/lib/jvm/java-8-openjdk-$(dpkg --print-architecture)" /docker-java-home                                                                                                                                                                                                                                                                                                                                                                                                                                                                                33B                 
<missing>                                                                 2 weeks ago         /bin/sh -c {   echo '#!/bin/sh';   echo 'set -e';   echo;   echo 'dirname "$(dirname "$(readlink -f "$(which javac || which java)")")"';  } > /usr/local/bin/docker-java-home  && chmod +x /usr/local/bin/docker-java-home                                                                                                                                                                                                                                                                                                                                                     87B                 
<missing>                                                                 2 weeks ago         /bin/sh -c #(nop)  ENV LANG=C.UTF-8                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            0B                  
<missing>                                                                 2 weeks ago         /bin/sh -c apt-get update && apt-get install -y --no-install-recommends   bzip2   unzip   xz-utils  && rm -rf /var/lib/apt/lists/*                                                                                                                                                                                                                                                                                                                                                                                                                                             2.05MB              
<missing>                                                                 2 weeks ago         /bin/sh -c set -ex;  if ! command -v gpg > /dev/null; then   apt-get update;   apt-get install -y --no-install-recommends    gnupg    dirmngr   ;   rm -rf /var/lib/apt/lists/*;  fi                                                                                                                                                                                                                                                                                                                                                                                           7.8MB               
<missing>                                                                 2 weeks ago         /bin/sh -c apt-get update && apt-get install -y --no-install-recommends   ca-certificates   curl   wget  && rm -rf /var/lib/apt/lists/*                                                                                                                                                                                                                                                                                                                                                                                                                                        23.8MB              
<missing>                                                                 2 weeks ago         /bin/sh -c #(nop)  CMD ["bash"]                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                0B                  
<missing>                                                                 2 weeks ago         /bin/sh -c #(nop) ADD file:b380df301ccb5ca09f0d7cd5697ed402fa55f3e9bc5df2f4d489ba31f28de58a in /                                                                                                                                                                                                                                                                                                                                                                                                                                                                               100MB 
@ubnt-yhlee

This comment has been minimized.

Copy link

ubnt-yhlee commented Mar 28, 2018

@yosifkit I don't think it's good. it should has git/svn/... (given that it's based on buildpack-deps:stretch-scm).

$ docker pull openjdk:8-jdk
8-jdk: Pulling from library/openjdk
c73ab1c6897b: Pull complete 
1ab373b3deae: Pull complete 
b542772b4177: Pull complete 
0bcc3741ab14: Pull complete 
421d624d778d: Pull complete 
26ad58237506: Pull complete 
88ad3b24382b: Pull complete 
776df9bf9f1b: Pull complete 
Digest: sha256:ee9dc6c814d8b23f3b2f1fc142da32de74727f69defbb5e35a0e53078e3d7380
Status: Downloaded newer image for openjdk:8-jdk
$ docker run --rm -it openjdk:8-jdk dpkg -l git
dpkg-query: no packages found matching git
$
@yosifkit

This comment has been minimized.

Copy link
Member

yosifkit commented Mar 28, 2018

My bad, thought I saw that in the layers 😲. Let me go see what else I can poke.

@tianon

This comment has been minimized.

Copy link
Member

tianon commented Mar 29, 2018

Just to update, fixed rebuilds (and forced pushes) are still in progress.

@tianon

This comment has been minimized.

Copy link
Member

tianon commented Mar 29, 2018

Images are fixed, built, and pushed! At worst they'll be updated when https://doi-janky.infosiftr.net/job/put-shared/ runs next (and at best, they're already updated or will be shortly during the run that's going right now). 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.