New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Alpine thread stack size patch #237

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
1 participant
@tianon
Copy link
Member

tianon commented Sep 20, 2018

This patch was OK'd by a Ruby maintainer (https://bugs.ruby-lang.org/issues/14387#note-16), but hasn't been merged because it isn't generic enough to support glibc properly, which doesn't matter here (since we're Alpine-only in this context).

Closes #196

@ncopa do you see any issue with us applying this patch to all four currently supported versions (2.3, 2.4, 2.5, 2.6-rc)? The patch applies cleanly, so I was planning to just go for it assuming our basic "does Ruby appear to work properly?" smoke tests pass, but I'd appreciate your thoughts on whether that's safe to do

Apply Alpine thread stack size patch
This patch was OK'd by a Ruby maintainer (https://bugs.ruby-lang.org/issues/14387#note-16), but hasn't been merged because it isn't generic enough to support glibc properly, which doesn't matter here (since we're Alpine-only in this context).

@tianon tianon merged commit 99b6d94 into docker-library:master Sep 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tianon tianon deleted the infosiftr:thread-stack-fix branch Sep 28, 2018

tianon added a commit to infosiftr/stackbrew that referenced this pull request Oct 1, 2018

Update docker-library images
- `busybox`: 1.29.3, Buildroot 2018.08, Alpine 3.8
- `cassandra`: fix `cassandra.yaml` modification (docker-library/cassandra#160), `chown` fixes (docker-library/cassandra#158)
- `ghost`: `chown` fixes (docker-library/ghost#153)
- `julia`: 1.0.1
- `mariadb`: `chown` fixes (docker-library/mariadb#203)
- `mongo`: `chown` fixes (docker-library/mongo#305)
- `openjdk`: Oracle variants (docker-library/openjdk#235), 11 GA
- `owncloud`: `chown` fixes (docker-library/owncloud#105)
- `percona`: `chown` fixes (docker-library/percona#69)
- `php`: 7.3.0RC2
- `rabbitmq`: `chown` fixes (docker-library/rabbitmq#281)
- `redis`: `chown` fixes (docker-library/redis#166)
- `redmine`: `chown` fixes (docker-library/redmine#128)
- `ruby`: Alpine thread stack size fix (docker-library/ruby#237)
- `tomcat`: add JRE 11, remove EOL Tomcat 8.0 (docker-library/tomcat#133)

take-five added a commit to salemove/docker-jenkins-agents that referenced this pull request Oct 23, 2018

Backport thread stack size patch from official Ruby alpine repo
See docker-library/ruby#237 for more information
about the bug and the patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment