feature: adding getmail as an alternative to fetchmail

[LucidityCrash]

Description

Adding getmail as an alternative to Fetchmail

Fixes #2513

Type of change

• New feature (non-breaking change which adds functionality)

Checklist:

• [?] My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (README.md or the documentation under docs/)
• [?] If necessary I have added tests that prove my fix is effective or that my feature works
• [?] New and existing unit tests pass locally with my changes

all of no_container.bats show fails
test_helper.bats has a fails:
✗ wait_for_smtp_port_in_container returns immediately when port found in 10400ms [10400]
318 tests, 9 failures, 4 skipped in 2025 seconds
I don't believe these are to do with my additions.

I've added a stub for testing but since getmail doesn't run as as daemon like fetchmail I'm not sure how to test.
Added some docs and basic config examples.

Not sure that putting the [options] section into a seperate file that is appended to each of the fetch configs as you might actually want different configs for different sources.

Note I'm downloading the sid version of getmail6 as the stable one is quite a bit out of date.

[polarathene]

Partial review as the browser crashed, but this was salvaged thankfully.

[polarathene]

Remainder of review completed 😀

[polarathene]

I used this online crontab tool, which should link to an example of every 29th minute. You'll see that it's only within an hour, then it resets. So every 50th minute would be always at 50 minutes past the current hour, technically every hour at that point.. same with every 31 minutes.

Thus I think the actual max is 30? (Every 30 minutes) Otherwise it's effectively hourly from then on, and anything after 60 likewise ends up being every hour (just with no offset).

I don't know cron that well, the other maintainers can provide feedback on that.

---

I'm going to batch commit the suggestions, so only the remaining feedback after (3 items left) that needs to be addressed 👍

• su -s decision deferred to another reviewer.
• xoauth docs link.
• Adding tests (once everything else is approved).

[georglauterbach]

Looks very good, just some minor stylistic issues. I hope you can just batch-commit my suggestions :)

[georglauterbach]

This can now be merged when the comments are resolved :)

[georglauterbach]

Applied my own review feedback as well to make the final reviews faster :)

[georglauterbach]

From a scripts perspective, LGTM. I hope all tests pass now :)

[polarathene]

I will batch commit these changes.

Fixes some typos, and uses permalinks instead of referencing lines on the master branch which is not a stable reference we can rely on.

[polarathene]

We still may want to consider tests.

If I understand this feature correctly. We could test it by having two DMS containers running, and treating one of them as the remote mail-server (the role of gmail for example)?

Additionally, here is the getmail6 bats test file that uses DMS to handle it's testing. I haven't looked through it properly yet.

[georglauterbach]

Yes, I'd like to see some tests as well - good idea :)

[polarathene]

I've assigned myself, but welcome anyone else to tackle the remaining task of getting some tests sorted.

This is a low priority for me and may not be something I can work on until December.

[LucidityCrash]

Actually found a few minutes ... think I got it this time :

ok 18 [Getmail] default configuration exists and is correct in 350ms
ok 19 [Getmail] debug-getmail works as expected in 993ms

and the tests in my fork are green :)

[georglauterbach]

Looks good! I will have a look tomorrow for final review 🚀

[georglauterbach]

Looks good to me now :) Maybe @casperklein want to have another look at this as well, and I think there is one comment from him that should also be resolved. But overall, nice work 🚀

[casperklein]

Just some small change requests. Otherwise ready to merge.

[georglauterbach]

@casperklein I went ahead and applied your feedback at this point. If all checks pass, I will take care of merging this (so we can get it into v12.2.0/v13.0.0).

[georglauterbach]

It seems I can't merge because of the request for changes that's still blocking 🫠 I could circumvent this as an administrator, but I won't 😂 I enabled auto-merge, so as soon as you approve @casperklein this PR will be merged.

[github-actions]

Documentation preview for this PR is ready! 🎉

Built with commit: 38d9adb