Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for ACR #548

Merged
merged 1 commit into from Jan 27, 2022
Merged

Add e2e tests for ACR #548

merged 1 commit into from Jan 27, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 27, 2022

Ref. #235

Follow-up docker/login-action#49

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Jan 27, 2022

Looks like if the repository is not created on the registry it fails to push the first time:

#39 exporting to image
#39 74.32 error: failed commit on ref "layer-sha256:916934d2283843834ac0148e6b496680813b6e403cac56f7f69b9ece61ccc487": unexpected status: 500 Internal Server Error
#39 74.32 retrying in 1s
#39 pushing layers 75.5s done
#39 pushing manifest for officialgithubactions.azurecr.io/test-docker-action:e2e-acr@sha256:fd08dce19a5fda9a6471b644b31180498678a9a4d402bb18ce329d619c570599
#39 149.0 error: failed commit on ref "manifest-sha256:b36bc93e2210afc0444c550202408ef1debc1c024c50aa5cfcdce38be605d5e7": unexpected status: 500 Internal Server Error
#39 149.0 retrying in 1s
#39 222.8 error: failed commit on ref "manifest-sha256:70187baa386b1dd4e7ac1cbfeccb2702b03e31270af172fb544a2c44d91619a1": unexpected status: 500 Internal Server Error
#39 222.8 retrying in 1s
#39 298.9 error: failed commit on ref "manifest-sha256:e3426f40f7c016f9bd04ef259530ea3f60b2c7b3f340c544d5a5cda368b7ee2f": unexpected status: 500 Internal Server Error
#39 298.9 retrying in 1s
Error: The operation was canceled.

On second run everything looks good:

#38 exporting to image
#38 pushing layers 1.4s done
#38 pushing manifest for officialgithubactions.azurecr.io/test-docker-action:e2e-acr@sha256:de3fae526513ccb6f5d07d82242789687857442773a2b8ab4d665c351a2ec7ee
#38 pushing manifest for officialgithubactions.azurecr.io/test-docker-action:e2e-acr@sha256:de3fae526513ccb6f5d07d82242789687857442773a2b8ab4d665c351a2ec7ee 3.3s done
#38 DONE 4.8s

#42 exporting cache
#42 preparing build cache for export 0.0s done
#42 DONE 0.0s

I guess ACR takes some time to create the repo?

cc @tonistiigi @chris-crone @RomainBelorgey

@crazy-max crazy-max marked this pull request as ready for review Jan 27, 2022
@RomainBelorgey
Copy link

@RomainBelorgey RomainBelorgey commented Jan 27, 2022

I guess ACR takes some time to create the repo?

Maybe 😅

@crazy-max crazy-max merged commit f4cf574 into docker:master Jan 27, 2022
26 checks passed
@crazy-max crazy-max deleted the e2e-acr branch Jan 27, 2022
@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Jan 27, 2022

@SteveLasker Not critical but if you have an idea about #548 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants