Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-cache-filters input #653

Merged
merged 1 commit into from Jul 19, 2022
Merged

Conversation

crazy-max
Copy link
Member

fixes #645

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max requested review from tonistiigi and jedevc Jul 18, 2022
@jedevc
Copy link
Member

jedevc commented Jul 18, 2022

See comment here

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

See comment here

Yes indeed, not sure myself as we currently make inputs plural in this action like outputs.

@jedevc
Copy link
Member

jedevc commented Jul 19, 2022

we currently make inputs plural in this action like outputs

Ah sorry, I got confused. Makes sense to allow this field as this then, but long-term may be worth discussing about option consistency throughout actions/buildx/bake.

jedevc
jedevc approved these changes Jul 19, 2022
@crazy-max crazy-max merged commit 1cb9d22 into docker:master Jul 19, 2022
34 checks passed
@crazy-max crazy-max deleted the no-cache-filters branch Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add no-cache-filter
2 participants