Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: comment on availability of built images in other build steps #665

Merged
merged 2 commits into from Oct 7, 2022

Conversation

baibaratsky
Copy link
Contributor

No description provided.

@baibaratsky baibaratsky requested a review from crazy-max as a code owner Aug 5, 2022
@crazy-max
Copy link
Member

crazy-max commented Aug 12, 2022

This is already the case when using load: true but yeah you can use the docker driver so you don't need to set load: true.

@baibaratsky
Copy link
Contributor Author

@crazy-max Just load: true doesn't allow you to use the built image in the next build step with the container driver. This is the point.

docs/advanced/export-docker.md Outdated Show resolved Hide resolved
@baibaratsky
Copy link
Contributor Author

@crazy-max I still think it would be useful to have these comments in the “export to Docker” section. It could save a lot of time to others.

@crazy-max
Copy link
Member

@baibaratsky Thanks for the changes. I think in a follow-up we might create a new page to reuse build result as it's a bit out of scope with "Export image to Docker" page. But in the meantime that sounds good to me.

Signed-off-by: Andrei Baibaratsky <andrei@baibaratsky.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member

Pushed extra commit with a dedicated page about named contexts. Removed the bake example that will be added in bake-action repo instead.

@crazy-max crazy-max merged commit e1a1035 into docker:master Oct 7, 2022
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants