metricutil: remove BUILDX_EXPERIMENTAL from internal docker reporting #2258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `BUILDX_EXPERIMENTAL` check is removed from the docker otel collector. We'll send metrics to the OTLP endpoint for docker desktop if it is present and enabled regardless of experimental status. The user-facing `OTEL` endpoints for enabling the metric reporting for external use is still hidden behind the experimental flag. We'll likely remove the experimental flag for this feature for v0.14. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
crazy-max
approved these changes
Feb 20, 2024
tonistiigi
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BUILDX_EXPERIMENTALcheck is removed from the docker otelcollector. We'll send metrics to the OTLP endpoint for docker desktop if
it is present and enabled regardless of experimental status.
The user-facing
OTELendpoints for enabling the metric reporting forexternal use is still hidden behind the experimental flag. We'll likely
remove the experimental flag for this feature for v0.14.