Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #2330
The
--loadcase is not properly handled in v0.13 and previous v0.12 as it doesn't append but overrides the outputs:{ "group": { "default": { "targets": [ "foo", "bar" ] } }, "target": { "bar": { "context": ".", "dockerfile": "Dockerfile", "output": [ "type=docker" ] }, "foo": { "context": ".", "dockerfile": "Dockerfile", "output": [ "type=docker" ] } } }With this change it will append only if there is a compatible output already (image, registry) or empty:
{ "group": { "default": { "targets": [ "foo", "bar" ] } }, "target": { "bar": { "context": ".", "dockerfile": "Dockerfile", "output": [ "type=docker" ] }, "foo": { "context": ".", "dockerfile": "Dockerfile", "output": [ "type=local,dest=out" ] } } }For example with:
It would result in:
{ "group": { "default": { "targets": [ "foo", "bar" ] } }, "target": { "bar": { "context": ".", "dockerfile": "Dockerfile", "output": [ "type=docker" ] }, "foo": { "context": ".", "dockerfile": "Dockerfile", "output": [ "type=image" "type=docker" ] } } }Same has been done for push override so we are consistent. See new tests suite for more info.