Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
manifest subcommand creates invalid manifest list #1135
Currently creating manifest lists from the experimental manifest subcommand uses an incorrect for the manifest, creating invalid manifests. These manifests fail to be pullable with containerd since containerd validates the size. This has lead to broken images being pushed to registries.
See conversation from containerd/containerd#2401
From looking at the code the issue seems to be that the original manifest is not stored in the original form and instead it is reserialized inside a new json object
Odd. There was an issue (that I can't find now) about this. And I went to a lot of trouble to get it back to looking exactly the way it looked originally. The issue had to do with the manifest changing (just the tabs in it), and so the hash was different. If anyone has that in their history or inbox please link.
@dmcgowan what version of the cli do you have?
referenced this issue
Jun 22, 2018
Answering containerd/containerd#2401 (comment)
@tonistiigi so you're right if you restrict yourself exclusively to code comments of the exported functions/fields. But then, only 3 lines below, this can be confusing:
Anyway, the current manifest code seems to need the unmarshalled