Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression in v18.06] Unknown top-level command should fail with non-zero exit code #1428

Closed
AkihiroSuda opened this issue Oct 10, 2018 · 3 comments · Fixed by #1429
Closed

[regression in v18.06] Unknown top-level command should fail with non-zero exit code #1428

AkihiroSuda opened this issue Oct 10, 2018 · 3 comments · Fixed by #1429

Comments

@AkihiroSuda
Copy link
Collaborator

Description

Unknown top-level command should fail with non-zero exit code

Steps to reproduce the issue:

$ docker foobar
$ exit $?

Describe the results you received:

0

Describe the results you expected:

1

Output of docker version:

Client:
 Version:           19.03.0-dev
 API version:       1.39
 Go version:        go1.10.4
 Git commit:        ab50c2f2
 Built:             Wed Oct 10 08:56:03 2018
 OS/Arch:           linux/amd64
 Experimental:      true
...
@AkihiroSuda
Copy link
Collaborator Author

This is regression in v18.06

$ docker run --rm docker:18.05 docker foobar;  echo $?
docker: 'foobar' is not a docker command.
See 'docker --help'
1
$ docker run --rm docker:18.06 docker foobar; echo $?
                                                                             
Usage:  docker [OPTIONS] COMMAND
...
Run 'docker COMMAND --help' for more information on a command.
0

@AkihiroSuda AkihiroSuda changed the title Unknown top-level command should fail with non-zero exit code [regression in v18.06] Unknown top-level command should fail with non-zero exit code Oct 10, 2018
@AkihiroSuda
Copy link
Collaborator Author

regression in a3fe7d6

cc @thaJeztah ^^

AkihiroSuda added a commit to AkihiroSuda/cli that referenced this issue Oct 10, 2018
@AkihiroSuda
Fix docker invalid-subcommand regression
d708cad 
Starting with a3fe7d6,
`docker invalid-subcommand` did not exit with non-zero status.

Fix docker#1428

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda AkihiroSuda mentioned this issue Oct 10, 2018
Merged
@AkihiroSuda
Copy link
Collaborator Author

PR: #1429

thaJeztah pushed a commit to thaJeztah/cli that referenced this issue Oct 24, 2018
@AkihiroSuda @thaJeztah
Fix docker invalid-subcommand regression
ebe071a 
Starting with a3fe7d6,
`docker invalid-subcommand` did not exit with non-zero status.

Fix docker#1428

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
(cherry picked from commit d708cad)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this issue Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docker invalid-subcommand regression AkihiroSuda/cli
1 participant
@AkihiroSuda