[18.09 backport] Add bash completion for experimental CLI commands (manifest) #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This preapares bash completion for more context sensitivity: - experimental cli features - orchestrator specific features Also renames _daemon_ to _server_ where used in context of `docker version` because the fields there are grouped unter _Server_. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 564d4da) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This is needed for implementing bash completion for the `docker manifest` command family. Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit a183c95) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 0fb4256) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## 18.09 #1542 +/- ##
=======================================
Coverage 54.06% 54.06%
=======================================
Files 290 290
Lines 19403 19403
=======================================
Hits 10490 10490
Misses 8241 8241
Partials 672 672 |
|
Thanks for reviewing 🤗 @vdemeester @andrewhsu PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1252 for 18.09
cherry-pick was clean; no conflicts
This adds bash completion for
docker manifestand its subcommands.Completion for the
manifestcommand is only activated if experimental CLI features are enabled (either by setting"experimental": "enabled"in .docker/config.json or the env varDOCKER_CLI_EXPERIMENTAL=enabled). This configuration setting is harvested from the output ofdocker version.Before adding the third configuration setting that is extracted from
docker version's output , I refactored the existing logic to a more consistent and clearer state. There is only one call todocker version. It is executed lazily and caches its result.Note: The initial concept also included gathering the orchestrator in this step, but this piece of information went bananas in #1137.
In the context of
docker versionand its output, I changed the domain language to use server instead of daemon because this is the term used there (bounded context). daemon is better suited for local calls whereas server is more appropriate for (potentially) remote calls.Edit: The list of valid os/arch values was taken from
validOSArchesin util.go. A comment was left as a reminder to keep both files in sync.