Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[carry] Add support for `template_driver` in composefiles #1746

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@thaJeztah
Copy link
Member

commented Mar 18, 2019

Carry of #1100 - rebased, and moved the option to schema 3.8
closes #1100

This maps the --template-driver flag on secret and config creation.

@thaJeztah

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 18, 2019

Codecov Report

Merging #1746 into master will decrease coverage by 0.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #1746      +/-   ##
==========================================
- Coverage    56.1%   56.09%   -0.02%     
==========================================
  Files         306      306              
  Lines       21049    21057       +8     
==========================================
+ Hits        11810    11812       +2     
- Misses       8382     8386       +4     
- Partials      857      859       +2
1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Mar 18, 2019

Codecov Report

Merging #1746 into master will decrease coverage by 0.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #1746      +/-   ##
==========================================
- Coverage    56.1%   56.09%   -0.02%     
==========================================
  Files         306      306              
  Lines       21049    21057       +8     
==========================================
+ Hits        11810    11812       +2     
- Misses       8382     8386       +4     
- Partials      857      859       +2
@silvin-lubecki
Copy link
Contributor

left a comment

LGTM

@vdemeester
Copy link
Member

left a comment

Thanks 😍 LGTM 🦁
… but needs a rebase @thaJeztah

@thaJeztah

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

ah, saw that one coming 😅 - working on another PR, but I'll update after 👍

Add support for `template_driver` in composefiles
This maps the `--template-driver` flag on secret and config creation.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@thaJeztah thaJeztah force-pushed the thaJeztah:carry_compose_template_driver branch from 2b46921 to 7764101 Mar 18, 2019

@thaJeztah

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

rebased; regenerated cli/compose/schema/bindata.go

@vdemeester vdemeester merged commit 2871b72 into docker:master Mar 19, 2019

8 of 9 checks passed

codecov/patch 40% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 56.25% (-0.02%) compared to 8c3a619
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Mar 19, 2019

@thaJeztah thaJeztah deleted the thaJeztah:carry_compose_template_driver branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.