Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systctl support for services #1754

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@thaJeztah
Copy link
Member

commented Mar 19, 2019

cli changes for moby/moby#37701

@thaJeztah

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

@thaJeztah thaJeztah added this to the 18.09.4 milestone Mar 19, 2019

@thaJeztah thaJeztah force-pushed the thaJeztah:add_sysctls_for_services branch 2 times, most recently from 6327aa3 to bb72d64 Mar 19, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 19, 2019

Codecov Report

Merging #1754 into master will increase coverage by 0.05%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   56.27%   56.32%   +0.05%     
==========================================
  Files         307      307              
  Lines       21151    21163      +12     
==========================================
+ Hits        11902    11920      +18     
+ Misses       8382     8378       -4     
+ Partials      867      865       -2
@silvin-lubecki
Copy link
Contributor

left a comment

LGTM 👍

@albers
Copy link
Member

left a comment

Completion LGTM. Flag annotation looks odd.

Show resolved Hide resolved cli/command/service/create.go
Add systctl support for services
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@thaJeztah thaJeztah force-pushed the thaJeztah:add_sysctls_for_services branch from bb72d64 to f620349 Mar 19, 2019

@albers

albers approved these changes Mar 19, 2019

@vdemeester
Copy link
Member

left a comment

LGTM 🐯

@thaJeztah thaJeztah merged commit 9a39a10 into docker:master Mar 19, 2019

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 92.3% of diff hit (target 50%)
Details
codecov/project 56.32% (+0.05%) compared to a4a50de
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@thaJeztah thaJeztah deleted the thaJeztah:add_sysctls_for_services branch Mar 19, 2019

@andrewhsu andrewhsu modified the milestones: 18.09.4, 19.03.0 Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.