Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump docker-credential-helpers v0.6.2 #1935

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
6 participants
@thaJeztah
Copy link
Member

commented Jun 11, 2019

full diff: docker/docker-credential-helpers@5241b46...8a9f93a

includes:

bump docker-credential-helpers v0.6.2
full diff: docker/docker-credential-helpers@5241b46...8a9f93a

includes:

- docker/docker-credential-helpers#29 C.free(unsafe.Pointer(err)) -> C.g_error_free(err)
- docker/docker-credential-helpers#124 pass: changed the way for checking if password-store is initalized
  - addresses docker/docker-credential-helpers#133 docker-credential-pass commits about 10 times every time I run a docker command
- docker/docker-credential-helpers#143 Fix docker-credential-osxkeychain list behaviour in case of missing entry in keychain
- docker/docker-credential-helpers#139 make docker-credential-wincred work like docker-credential-osxkeychain

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #1935 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1935   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files         310      310           
  Lines       21800    21800           
=======================================
  Hits        12367    12367           
  Misses       8518     8518           
  Partials      915      915
@LaurentDumont

This comment has been minimized.

Copy link

commented Jun 20, 2019

Just got bit by this. Looking forward to the merge 👯‍♂

@thaJeztah

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

ping @vdemeester @silvin-lubecki PTAL

@vdemeester
Copy link
Member

left a comment

LGTM 🐯

@thaJeztah thaJeztah merged commit b45b4b2 into docker:master Jun 20, 2019

9 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 32d7596...f6a4c76
Details
codecov/project 56.72% remains the same compared to 32d7596
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 19.09.0 milestone Jun 20, 2019

@thaJeztah thaJeztah deleted the thaJeztah:bump_credential_helpers branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.