New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using nature sort secrets and configs in cli #307

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
9 participants
@allencloud
Member

allencloud commented Jul 7, 2017

Signed-off-by: allencloud allen.sun@daocloud.io

- What I did

  1. sort secrets and configs in cli

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@dnephin

dnephin approved these changes Jul 7, 2017

LGTM

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Jul 7, 2017

Collaborator

Although some tests do need to be updated

Collaborator

dnephin commented Jul 7, 2017

Although some tests do need to be updated

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jul 7, 2017

Collaborator

I think this should use the "natural sort" like #302. ping @ripcurld0

Collaborator

aaronlehmann commented Jul 7, 2017

I think this should use the "natural sort" like #302. ping @ripcurld0

@allencloud

This comment has been minimized.

Show comment
Hide comment
@allencloud

allencloud Jul 8, 2017

Member

Thanks for your feedback, I will do a change. @aaronlehmann
In addition, @dnephin , I think this PR fails to trigger the CI.

Member

allencloud commented Jul 8, 2017

Thanks for your feedback, I will do a change. @aaronlehmann
In addition, @dnephin , I think this PR fails to trigger the CI.

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Jul 11, 2017

Collaborator

hmm, not sure why that is. Maybe cirlceci was having issues?

Have you setup circleci on your fork? I think that can cause problems sometimnes

Collaborator

dnephin commented Jul 11, 2017

hmm, not sure why that is. Maybe cirlceci was having issues?

Have you setup circleci on your fork? I think that can cause problems sometimnes

@yuexiao-wang

This comment has been minimized.

Show comment
Hide comment
@yuexiao-wang

yuexiao-wang Jul 13, 2017

Contributor

@allencloud This PR needs to be rebased

Contributor

yuexiao-wang commented Jul 13, 2017

@allencloud This PR needs to be rebased

@boaz1337

👍 LGTM

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jul 21, 2017

Collaborator

CI is failing

cli/command/config/ls_test.go:80: use of package assert without selector
cli/command/config/ls_test.go:81: use of package assert without selector
Collaborator

aaronlehmann commented Jul 21, 2017

CI is failing

cli/command/config/ls_test.go:80: use of package assert without selector
cli/command/config/ls_test.go:81: use of package assert without selector
@allencloud

This comment has been minimized.

Show comment
Hide comment
@allencloud

allencloud Jul 23, 2017

Member

Thanks for your feedback. @aaronlehmann
I will turn to this PR in few days. Sorry for the delay. ☀️

Member

allencloud commented Jul 23, 2017

Thanks for your feedback. @aaronlehmann
I will turn to this PR in few days. Sorry for the delay. ☀️

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester
Member

vdemeester commented Sep 20, 2017

@allencloud ping 👼

@allencloud allencloud changed the title from sort secrets and configs in cli to using nature sort secrets and configs in cli Sep 25, 2017

sort secrets and configs in cli
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 25, 2017

Codecov Report

Merging #307 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   49.22%   49.26%   +0.04%     
==========================================
  Files         200      200              
  Lines       16453    16465      +12     
==========================================
+ Hits         8099     8112      +13     
+ Misses       7934     7933       -1     
  Partials      420      420

codecov-io commented Sep 25, 2017

Codecov Report

Merging #307 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   49.22%   49.26%   +0.04%     
==========================================
  Files         200      200              
  Lines       16453    16465      +12     
==========================================
+ Hits         8099     8112      +13     
+ Misses       7934     7933       -1     
  Partials      420      420
@allencloud

This comment has been minimized.

Show comment
Hide comment
@allencloud

allencloud Sep 25, 2017

Member

Sorry for the delay. And I have updated this PR to use natural sort to sort docker cli config/secret ls output. PTAL @dnephin @aaronlehmann @vdemeester

Member

allencloud commented Sep 25, 2017

Sorry for the delay. And I have updated this PR to use natural sort to sort docker cli config/secret ls output. PTAL @dnephin @aaronlehmann @vdemeester

@vdemeester

LGTM 🐯

@vdemeester vdemeester merged commit bd6e175 into docker:master Sep 25, 2017

8 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 49.26% (+0.04%) compared to a41caad
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.10.0 milestone Sep 25, 2017

@allencloud allencloud deleted the allencloud:sort-secrets-and-configs-in-cli branch Sep 25, 2017

jeanlaurent added a commit to jeanlaurent/cli that referenced this pull request Sep 25, 2017

Merge pull request docker#307 from allencloud/sort-secrets-and-config…
…s-in-cli

using nature sort secrets and configs in cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment