New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stop-signal in stack command #388

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
7 participants
@christopherobin
Contributor

christopherobin commented Jul 27, 2017

- What I did

Fixes #370 by passing StopSignal to the container spec when doing a deploy.

- How I did it

Passed StopSignal and removed stop_signal from unsupported keys.

- How to verify it

Create a small docker-compose file with a service defining a stop signal, deploy using docker stack deploy -c file.yml stack_name then inspect one of the created containers.

- Description for the changelog

Added support for stop_signal when deploying a compose file through docker stack.

- A picture of a cute animal (not mandatory but encouraged)

otter_madness

Add support for stop-signal in stack command
Signed-off-by: Christophe Robin <crobin@nekoo.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Jul 27, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 27, 2017

Codecov Report

Merging #388 into master will decrease coverage by 0.34%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   46.14%   45.79%   -0.35%     
==========================================
  Files         193      193              
  Lines       16073    16070       -3     
==========================================
- Hits         7417     7360      -57     
- Misses       8269     8324      +55     
+ Partials      387      386       -1

codecov-io commented Jul 27, 2017

Codecov Report

Merging #388 into master will decrease coverage by 0.34%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   46.14%   45.79%   -0.35%     
==========================================
  Files         193      193              
  Lines       16073    16070       -3     
==========================================
- Hits         7417     7360      -57     
- Misses       8269     8324      +55     
+ Partials      387      386       -1
@dnephin

LGTM

@docker docker deleted a comment from GordonTheTurtle Aug 1, 2017

@vdemeester

LGTM 🐯

@vdemeester vdemeester merged commit f386d47 into docker:master Aug 1, 2017

7 of 8 checks passed

codecov/patch 0% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 45.79% (-0.35%) compared to 2dac00b
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 1, 2017

@christopherobin christopherobin deleted the christopherobin:feature/stopsignal branch Aug 1, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Aug 1, 2017

Member

ping @londoncalling to verify if this needs docs updates

Member

thaJeztah commented Aug 1, 2017

ping @londoncalling to verify if this needs docs updates

@londoncalling

This comment has been minimized.

Show comment
Hide comment
@londoncalling

londoncalling Aug 2, 2017

Contributor

@thaJeztah , it looks like we have this in the Compose file reference, but currently say it's ignored by docker stack deploy: https://docs.docker.com/compose/compose-file/#stop_signal

Is the first part of this docs update to remove the caveat here re: docker stack deploy (as it's now supported)? And update the versioning information?

Regarding Compose CLI support, I assume this warrants a new Compose CLI command topic?

Contributor

londoncalling commented Aug 2, 2017

@thaJeztah , it looks like we have this in the Compose file reference, but currently say it's ignored by docker stack deploy: https://docs.docker.com/compose/compose-file/#stop_signal

Is the first part of this docs update to remove the caveat here re: docker stack deploy (as it's now supported)? And update the versioning information?

Regarding Compose CLI support, I assume this warrants a new Compose CLI command topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment