New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print timestamp when --human=true #438

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
5 participants
@boaz1337
Contributor

boaz1337 commented Aug 12, 2017

This PR closes #437

- What I did

  • Setting --human=true changes CreatedSince format
  • CreatedAt now displays the creation timestamp as specified in the documents

- How I did it

  • Updated historyContext.CreatedSince and historyContext.CreatedAt in cli/command/formatter/history.go
  • Added a test-case to cli/command/formatter/history_test.go

- How to verify it

Run unit tests

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Print timestamp when --human=true
* Setting "--human=true" changes "CreatedSince" format

* "CreatedAt" now displays the creation timestamp as
  specified in the documents

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 12, 2017

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage   46.28%   46.3%   +0.02%     
=========================================
  Files         194     194              
  Lines       16134   16137       +3     
=========================================
+ Hits         7467    7472       +5     
+ Misses       8278    8276       -2     
  Partials      389     389

codecov-io commented Aug 12, 2017

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage   46.28%   46.3%   +0.02%     
=========================================
  Files         194     194              
  Lines       16134   16137       +3     
=========================================
+ Hits         7467    7472       +5     
+ Misses       8278    8276       -2     
  Partials      389     389
@vdemeester

LGTM 🐸

@thaJeztah

LGTM, thanks!

@thaJeztah thaJeztah merged commit 898f1e2 into docker:master Aug 14, 2017

8 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 46.3% (+0.02%) compared to 4b61f56
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment