Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show images digests when "{{.Digest}}" is in format #439

Merged
merged 1 commit into from Aug 22, 2017

Conversation

@boaz0
Copy link
Contributor

commented Aug 14, 2017

- What I did

This patch fixes the following bug #435:

Running "docker image ls --digests" will add images digests
to the image table. However, when using "format" to display
images digests all of them are "".

- How I did it

In cli/command/formatter/image.go if either --digests is true or {{.Digest}} is in --format then display the image digest. Otherwise, set it to nil.

- How to verify it

Run unit-tests

- Description for the changelog
Fix #435

- A picture of a cute animal (not mandatory but encouraged)

@dnephin
Copy link
Collaborator

left a comment

LGTM

@boaz0

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2017

Have no idea why test keeps failing. 🤔🐺

@dnephin

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2017

It's failing to upload code coverage to codedov service. It might be down. It's not related to your change.

Show images digests when "{{.Digest}}" is in format
This patch fixes the following bug:

Running "docker image ls --digests" will add images digests
to the image table. However, when using "format" to display
images digests all of them are "<none>".

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

commented Aug 22, 2017

Codecov Report

Merging #439 into master will decrease coverage by 0.73%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   47.01%   46.28%   -0.74%     
==========================================
  Files         198      194       -4     
  Lines       16334    16136     -198     
==========================================
- Hits         7680     7468     -212     
- Misses       8260     8279      +19     
+ Partials      394      389       -5
@vdemeester
Copy link
Member

left a comment

LGTM 🦁

@vdemeester vdemeester merged commit 317b735 into docker:master Aug 22, 2017

8 checks passed

ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project Absolute coverage decreased by -0.73% but relative coverage increased by +52.98% compared to 8da1dae
Details
dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.