Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
LCOW: CLI changes to add platform flag - pull, run, create and build #474
Signed-off-by: John Howard email@example.com
referenced this pull request
Aug 27, 2017
@@ Coverage Diff @@ ## master #474 +/- ## ========================================== - Coverage 50.1% 49.54% -0.56% ========================================== Files 216 211 -5 Lines 17700 17480 -220 ========================================== - Hits 8868 8661 -207 + Misses 8388 8386 -2 + Partials 444 433 -11
Rebased to address conflicts, and reworked to use two utility functions rather than replicate the same code in a few places.
Ready for review, removed WIP from the title, updated the commit comment and the description of the PR. @vdemeester can this be moved to code review now?
I still think we should hide this flag when the list of supported platforms returned by the API has a length of 1.
That would be handled by adding another field to
ServerInfo in cli/command/cli.go
, and calling a new function fromhideUnsupportedFeatures()